Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'runWithClient' example to http-integration.mdx #10979

Merged
merged 6 commits into from
Aug 27, 2024
Merged

add 'runWithClient' example to http-integration.mdx #10979

merged 6 commits into from
Aug 27, 2024

Conversation

martinhaintz
Copy link
Collaborator

DESCRIBE YOUR PR

Based on the issue in the sentry-dart repo 1192, I added an example for using the runWithClient function.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024

@martinhaintz is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@martinhaintz martinhaintz marked this pull request as ready for review August 5, 2024 15:52
@vercel Vercel
Copy link

vercel bot commented Aug 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 1:11pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 1:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 1:11pm

@buenaflor
Copy link
Contributor

@martinhaintz quick reminder for the pending comments

@buenaflor buenaflor enabled auto-merge (squash) August 19, 2024 12:25
@buenaflor
Copy link
Contributor

@kahest need a re-run pls

vivianyentran
vivianyentran approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the wording a bit

docs/platforms/dart/integrations/http-integration.mdx Outdated Show resolved Hide resolved
@buenaflor
Copy link
Contributor

@kahest need a rerun pls

@buenaflor buenaflor merged commit 3ee824a into getsentry:master Aug 27, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buenaflor buenaflor buenaflor approved these changes

@vivianyentran vivianyentran vivianyentran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinhaintz @buenaflor @vivianyentran @mar-hai